search

whamtet / simpleui

JS Free Single Page Applications
https://simpleui.io
Eclipse Public License 2.0
251 stars 15 forks source link

Latest ctmx version in luminus template. #24

Closed bobyuancn closed 1 year ago

bobyuancn commented 1 year ago

here are the steps to reproduce the failure.

  1. Generate a new project.
lein new luminus helloctmx +http-kit +ctmx

  1. Run it with lein run. It works well with old version ctmx 1.4.3 in project.clj as dependency.

  2. Update the ctmx version to latest 1.4.8, and re-run the project. We see error like this:

java.lang.ClassCastException: class java.lang.String cannot be cast to class java.lang.Number (java.lang.String and java.lang.Number are in module java.base of loader 'bootstrap')
        at clojure.lang.Numbers.inc(Numbers.java:139)

Minor version usually should be compatible, so maybe you can check on this when free, thanks!

Luminus template is having "Added +ctmx option (#544)" last year, but not listed in the table below. https://github.com/luminus-framework/luminus-template

I think it is better add ctmx in the table if luminus template officially support it, do you think so?

whamtet commented 1 year ago

@bobyuancn its annoying to update the luminus demo, I explained how to run kit based demo instead in the other issue. You can fix the bug above by going to helloctmx.routes.home and changing :^int num-clicks to :^long num-clicks.

whamtet commented 1 year ago

You're right I've messed up the semantic versioning. Technically it should be a major version increment if I remove support for ^:int casts.