Support symbol of value 0

wharfkit / antelope

Core types, client interfaces, and other tools for working with Antelope-based blockchains.

Other

42 stars 23 forks source link

Support symbol of value 0 #98

Closed mschoenebeck closed 5 months ago

mschoenebeck commented 5 months ago

The current implementation of Wharfkit doesn't support the valid EOSIO symbol of zero value. While the EOSIO asset type (unfortunately) doesn't support this symbol value the EOSIO symbol type indeed does. Symbols of value zero are useful to encode NFT assets according to the AtomicAssets standard.

This PR adds support for symbols of zero value encoded by the symbol string "0,".

aaroncox commented 5 months ago

Sorry for the delay - and thanks for the PR!

I've been chatting with the team in Slack about this change, and there were only a few nitpicky things we can quickly correct.

aaroncox commented 5 months ago

This is now released as wharfkit/antelope v1.0.5.