If the lower or upper bounds are a value of zero, this check just nulls them out

wharfkit / contract

Access table data, create actions, and retrieve types for Antelope-based Smart Contracts

https://wharfkit.com

Other

1 stars 1 forks source link

If the lower or upper bounds are a value of zero, this check just nulls them out #70

Open aaroncox opened 3 months ago

aaroncox commented 3 months ago

https://github.com/wharfkit/contract/blob/eec0425c87b8b5d6699f2a4e6b6b9903355f9321/src/utils.ts#L62-L64

This prevents a JS value of 0 from being used in the query. It just sets those fields as empty values. We need a better check here to get around these things that are false-y in JS.

SleepingProgrammer commented 3 months ago

Thank you for documenting this 🙇‍♂️ Just gonna comment to follow this issue until it gets fixed so I can update the workaround I made.