search

wharfkit / wallet-plugin-anchor

WalletPlugin for the Wharf Session Kit. Allow users to login and sign transactions with the Anchor authenticator.
https://wharfkit.com
Other
2 stars 3 forks source link

dafuga - dev #2

Closed dafuga closed 1 year ago

dafuga commented 1 year ago

I did run make check 😄

aaroncox commented 1 year ago

I must have run it at a weird time, it was failing for me when I left the comment - and now it works.

Also go figure I just broke this PR when I accidentally committed this to remove the uuid library 😂

https://github.com/wharfkit/wallet-plugin-anchor/commit/780150e69884932d885aa642739af593610f5548#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L24-R23

dafuga commented 1 year ago

Yeah sounds good! Let's get this plugin in a good place first and then I can work on putting all the esr stuff in a separate plugin 👍

aaroncox commented 1 year ago

Oh and one other note, this isn't going to work well with the web ui renderer tests until the uuid library is removed. We need to find something to replace that with, or modify the build process to include the parts of crypto it needs to function.

Maybe we swap it for something like: https://github.com/lukeed/uuid

Either that or we go nuts and stop with UUIDs and use something like https://github.com/ai/nanoid

@jnordberg Do we need to use UUIDs here?

jnordberg commented 1 year ago

If we are talking about session channels for buoy nanoid should be fine, just make it big enough to never collide