search

wharton / chef-shibboleth-sp

Chef Shibboleth Service Provider Cookbook
7 stars 12 forks source link

Added logging root attribute and shibd.logger template #4

Closed bflad closed 11 years ago

bflad commented 11 years ago

Please let me know if you have any questions/concerns.

nmische commented 11 years ago

Good start, but I I'd like to see support for tracing of SAML messages. Don't let that hold up this PR though.

bflad commented 11 years ago

How about all dem attributes?

nmische commented 11 years ago

What if we only add the line to the config if one of those additional attributes is defined?

bflad commented 11 years ago

They're originally part of the configuration commented out, but set as INFO because root is INFO by default. I'm flexible with the implementation, but it would make for a harder to read template file if we're just controlling the # in front of the configuration line for when its set to DEBUG.

nmische commented 11 years ago

Yeah, I just realized after looking at 213bd81 that it would be nice to still be able to quickly set everything to DEBUG with the root logging level. It may not be worth the complexity though.

bflad commented 11 years ago

We could change node['shibboleth-sp']['logging'] to just uncomment all of those additional lines. One quick and dirty change for a bunch more logging.

nmische commented 11 years ago

@bflad Not sure if you care about this anymore, but this is what I think I'm going to do here.

bflad commented 11 years ago

fine by me.