fix save_virtual_workbook deprecation/removal in openpyxl 3.1.0

wharton / drf-excel

An XLSX spreadsheet renderer for Django REST Framework.

BSD 3-Clause "New" or "Revised" License

212 stars 40 forks source link

fix save_virtual_workbook deprecation/removal in openpyxl 3.1.0 #72

Closed alb3rto269 closed 1 year ago

alb3rto269 commented 1 year ago

Fixes https://github.com/wharton/drf-excel/issues/73

The proposed solution:

replaces the call to save_virtual_wookbook by its non-deprecated version save_wookbook.
migrates the logic previously implemented in save_virtual_wookbook from openpyxl to this repository.
replaces the usage of TemporaryFile by NamedTemporaryFile as suggested by the openpyxl author on its deprecation message.

FlipperPA commented 1 year ago

Thanks @alb3rto269 - merged to main, along with some refactoring. Let's test while I'm out of town for a day or two, and if everything looks good, I'll mint a new version on Monday. I'm also looking for a co-maintainer if you're interested; it looks like you might use the package reasonably frequently.