what-digital / divio

A project for tracking divio.com deployment issues
0 stars 0 forks source link

changes in aldryn_config.py (aldryn-django) are reverted by the Divio bot #47

Open nichoski opened 3 years ago

nichoski commented 3 years ago

Specific Case

We would like to enable Sentry APM for performance measurement

In aldryn_config.py file in aldryn-django addon, there are existing settings for sentry_sdk initiation. We need to add a traces_sample_rate setting which is needed for performances reporting by sentry. This:

            sentry_sdk.init(
                dsn=sentry_dsn,
                integrations=[DjangoIntegration()],
                debug=settings['DEBUG'],
                release=env('GIT_COMMIT', 'develop'),
                environment=env('STAGE', 'local'),
            )

Needs to be replaced with this:

            sentry_sdk.init(
                dsn=sentry_dsn,
                integrations=[DjangoIntegration()],
                debug=settings['DEBUG'],
                release=env('GIT_COMMIT', 'develop'),
                environment=env('STAGE', 'local'),
                traces_sample_rate=env('SENTRY_TRACES_SAMPLE_RATE', 1),
            )

However Divio Bot is resetting this change when we push the commit to our gitlab.com repository. As a workaround, we set up our own sentry sdk setup in settings.py

macolo commented 3 years ago

Hi @nichoski please reformulate so that your ticket includes a problem statement. (https://en.m.wikipedia.org/wiki/Problem_statement)

kinkerl commented 3 years ago

maybe this can also be reworked as a pullrequest on https://github.com/divio/aldryn-django ? this would allow us to better test and accept this change.

macolo commented 3 years ago

Note: I added a problem statement to the issue.