search

what3words / w3w-node-wrapper

Node wrapper for the What3Words API
https://docs.what3words.com/api/v3/
MIT License
45 stars 10 forks source link

Replaced request and lodash #14

Closed StephanGeorg closed 6 years ago

StephanGeorg commented 6 years ago

I replaced request with isomorphic-fetch so that you can use this in isomorphic environments. I also replaced lodash map/bind with the native functions. In the next step I would completely rewrite it in es6 and implement it with babel. What you think?

StephanGeorg commented 6 years ago

Ah, I saw the checks failed due to missing apiKey. Can you add one to the Travis tests?

tsamaya commented 6 years ago

Hi Stephan,

yes travis can not run on PR. I will have a look later this week. anycase it sounds promising and interesting thanks for your work.

Arnaud

On 04 Dec 2017, at 09:52, Stephan Georg notifications@github.com wrote:

Ah, I saw the checks failed due to missing apiKey. Can you add one to the Travis tests?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/what3words/w3w-node-wrapper/pull/14#issuecomment-348912669, or mute the thread https://github.com/notifications/unsubscribe-auth/ABqSCFxCImxKxZUF-W_lf1vu5RhTNQonks5s88DugaJpZM4QyjOR.

tsamaya commented 6 years ago

Hi Stephan seems OK for me, can you please bump version before I merge with: $ grunt version::minor

tsamaya commented 6 years ago

Can you also bump the version in https://github.com/StephanGeorg/w3w-node-wrapper/blob/master/lib/W3W.Geocoder.js#L21

that was the purpose of the command line with grunt 😉

StephanGeorg commented 6 years ago

Can you please publish it to NPM.

tsamaya commented 6 years ago

I removed the IOJS platform from list for the CI . Tests now pass and it is then published on NPM Great Stuff, thank you.