search

what3words / w3w-node-wrapper

Node wrapper for the What3Words API
https://docs.what3words.com/api/v3/
MIT License
45 stars 10 forks source link

Added validations, replaced bluebird and unirest #6

Closed StephanGeorg closed 8 years ago

StephanGeorg commented 8 years ago

Added some validations before executing the API in terms of speed and API usage. Replaced unirest with request and removed Bluebird. Can you tell me what is the advantage not to use the default promises?

sabarasaba commented 8 years ago

Changes look good man, thanks for helping!

When this module was written, node was in 0.12 and it just added native promises. But due to a memory leak issue, I ended up going for bluebird in order to avoid the issue.

sabarasaba commented 8 years ago

@StephanGeorg Actually, theres one more thing. Could you also update the readme.md file ? it seems to have a reference to bluebird. Cheers!

StephanGeorg commented 8 years ago

I removed the references to unirest and bluebird and some other. Would you please update the npm package as well?

sabarasaba commented 8 years ago

Sweet, I just asked @freyfogle to make me a contributor of the repo so that I can republish the package. Lets wait a bit until he sees these messages! Again, thanks a lot dude !

freyfogle commented 8 years ago

ok I think I gave you access. frankly I find github teams and organizations so confusing

sabarasaba commented 8 years ago

yeah, i got it now! will publish the package in a few min. Thanks @freyfogle !

sabarasaba commented 8 years ago

@StephanGeorg just published the package and fixed one of the tests that was broken. Thanks !

StephanGeorg commented 8 years ago

Cool, thanks!