Memory Leak issue in W3WMapViewController

what3words / w3w-swift-components

A swift library to use What3words autosuggest

MIT License

7 stars 12 forks source link

Memory Leak issue in W3WMapViewController #7

Closed ulian-onua closed 9 months ago

ulian-onua commented 11 months ago

There is memory leak issue in a method that happens because self isn't passed as [weak self] in the closures in the method public func set(_ w3w: W3WProtocolV3, language: String = W3WSettings.defaultLanguage) of W3WMapViewController.

I already prepared PR to fix that. https://github.com/what3words/w3w-swift-components/pull/6

andycurriew3w commented 11 months ago

Hi @ulian-onua ,

Many thanks for reporting the issue and submitting a PR. I have passed to our engineers to review and merge.

Andy

ulian-onua commented 11 months ago

@andycurriew3w thank you. I am looking forward to the review and merging these fixes.

dave-w3w commented 9 months ago

This has been merged, thanks!