search

whatadewitt / yahoo-fantasy-sports-api

NodeJS wrapper for the Yahoo! Fantasy Sports API
https://yahoo-fantasy-node-docs.vercel.app/
MIT License
200 stars 54 forks source link

Fixes unit tests #32

Closed stevehansell closed 7 years ago

stevehansell commented 7 years ago

Updated package.json to include the necessary dev dependencies for testing (jasmine-node, q). jasmine was removed as it is now included in jasmine-node.

Running jasmine-node with tests in subdirectories wasn't correctly running all of the tests. The fix for this was to move all of the tests into the tests directory. All require paths were updated within the tests to reflect the change.

Most of the failing tests were due to http vs https expectations and spy calls expecting a callback function. These were fixed by using Jasmine's .any(Function).

screenshot 2016-12-24 10 48 21

whatadewitt commented 7 years ago

Wowza! Thanks for this and sorry for my delayed response! I've been on holidays and have stayed away from the computer! I should be able to get this merged in this week at some point! Very exciting! Thank you!

stevehansell commented 7 years ago

No worries! Glad to be of help. 👍