Conforming to current jasmine api. Passing needed test values

whatadewitt / yahoo-fantasy-sports-api

NodeJS wrapper for the Yahoo! Fantasy Sports API

https://yahoo-fantasy-node-docs.vercel.app/

MIT License

192 stars 52 forks source link

Conforming to current jasmine api. Passing needed test values #42

Closed ryus08 closed 6 years ago

ryus08 commented 6 years ago

I started to implement https://github.com/whatadewitt/yfsapi/issues/41 and wanted to see if the existing tests still passed, but they weren't running.

Wanted to get them working for before adding the feature. Just a few things off, comments inline.

whatadewitt commented 6 years ago

I'll take a look at this tonight... funny thing is I actually made a bunch of changes locally but didn't merge them in yet as I still had a few things breaking... thanks!

ryus08 commented 6 years ago

Yeah, those changes you had were some of it. Still need to nock out some endpoints and provide a callback