search

whatawurst / android_device_sony_lilac

This is the Android device configuration for Sony Xperia XZ1 Compact (yoshino platform).
23 stars 26 forks source link

[lineage-18.1] Update #36

Closed derfelot closed 2 years ago

derfelot commented 3 years ago

Hold...still need to test & more coming

derfelot commented 3 years ago

Will drop the first commit, forgot I already merged the PR.

derfelot commented 3 years ago

@Flamefire FYI

isombyt commented 3 years ago

Wait a second. Are we dropping QCOM WFD support?

Flamefire commented 3 years ago

@isombyt Moved to yoshino-common: https://github.com/whatawurst/android_device_sony_yoshino-common/pull/55

derfelot commented 3 years ago

QCOM implementation isn't working for legacy devices anymore. But the AOSP way has been made available in 18.1 again. That's what that overlay in yoshino is for. Works fine according to my tests.

isombyt commented 3 years ago

lol. I just fixed the QCOM implementation before I saw this PR.

derfelot commented 3 years ago

Are you sure it was using the qcom implementation in the end and not the aosp inadvertently? I guess the qcom wfd icon (blue Q in white square iirc) popping up in notifications should tell.

afaik, any recent qcom implementation that would work on 11 depends on on updated display.config (iirc) and won't won't for us without issues.

pretty much all the "legacy" los devices have now dropped qcom stuff completely like i did here.

isombyt commented 3 years ago

Screenshot_20210918-115502_Settings You mean this icon? It works fine miraculously.

isombyt commented 3 years ago

Anyway.

Are you sure it was using the qcom implementation in the end and not the aosp inadvertently? I guess the qcom wfd icon (blue Q in white square iirc) popping up in notifications should tell.

afaik, any recent qcom implementation that would work on 11 depends on on updated display.config (iirc) and won't won't for us without issues.

pretty much all the "legacy" los devices have now dropped qcom stuff completely like i did here.

BTW, here's the changes, if you want to look into it. Works well on my lilac, not sure if it works on other devices. https://github.com/isombyt/android_device_sony_yoshino-common/commit/d5dada725fc914929110b6325645350089d26332 https://github.com/isombyt/android_vendor_sony_lilac/commit/065ef30e7a9e45b47cf4b3aabfdea0a9a785e9db https://github.com/isombyt/android_device_sony_lilac/commit/c50870b7bf5fadcb91ec4cf9ead7f79da6d4999b

Flamefire commented 2 years ago

Just FYI and for documentation: Backporting the WFD changes (i.e. the "Drop QCOM WFD" commits here and in yoshino-common) break the boot in LOS 17.1 (bootloop after LOS animation, no ADB connection)

derfelot commented 2 years ago

Yeah, you shouldn't include those. QCOM WFD works fine in 10.

Flamefire commented 2 years ago

Great, thought so! Thanks for confirming.