whatawurst / android_device_sony_lilac

This is the Android device configuration for Sony Xperia XZ1 Compact (yoshino platform).
23 stars 26 forks source link

Duplicate proprietary file entries #52

Closed Flamefire closed 1 year ago

Flamefire commented 1 year ago

I wrote a small script to verify existence of pinned files, correct checksums and detect duplicates. (And for me to create/check a .gitignore) and it turned up with those duplicates (in my branch based on yours so yours might have some removed already):

    lib/vendor.qti.hardware.qteeconnector@1.0.so
    lib64/vendor.qti.hardware.qteeconnector@1.0.so
    vendor/lib/libadiertac.so
    vendor/lib64/libadiertac.so
    vendor/etc/firmware/tztpm.b00
    vendor/etc/firmware/tztpm.b01
    vendor/etc/firmware/tztpm.b02
    vendor/etc/firmware/tztpm.b03
    vendor/etc/firmware/tztpm.b04
    vendor/etc/firmware/tztpm.b05
    vendor/etc/firmware/tztpm.b06
    vendor/etc/firmware/tztpm.b07
    vendor/etc/firmware/tztpm.mdt

And indeed: https://github.com/whatawurst/android_device_sony_lilac/blob/ef56b41cdde352470f8970ebbe13921ace4477bc/proprietary-files-vendor.txt#L14 https://github.com/whatawurst/android_device_sony_lilac/blob/ef56b41cdde352470f8970ebbe13921ace4477bc/proprietary-files-vendor.txt#L46

I doubt this is intentional.

My current working draft of the script is this: checkBlobs.py.txt

derfelot commented 1 year ago

Yeah, this is not intentional. I will also have a look at the other devices.

Thanks

Flamefire commented 1 year ago

I finished the script I used and put it into a branch of my repo: https://github.com/Flamefire/android_device_sony_yoshino-common/blob/lineage-17.1/tools/checkBlobs.py

Simple hacked Pythons script which does a couple sanity checks such as searching for duplicates and verifying checksums. As I also chose to not keep the files in the repo which can be copied from the image and add them (the unpinned ones) to the gitignore hence the switch. It should also be able to handle the vendor/yoshino_common in your repos. Just check if that helps.

derfelot commented 1 year ago

Removed all the duplicates I could find. Thanks