search

whatawurst / android_device_sony_yoshino-common

This is the Android device configuration for the yoshino platform
10 stars 48 forks source link

Apn update #59

Closed Flamefire closed 2 years ago

Flamefire commented 2 years ago

First commit is basically from https://github.com/Flamefire/android_device_sony_yoshino-common/commit/3d368da18b2768a3db8ddb91f97913b60b882f54

For the rest I used a custom script to sort the APNs by MCC, MNC, Name and then added all APNs from https://android.googlesource.com/device/sample/+/refs/heads/master/etc/apns-full-conf.xml for which we don't have the MCC/MNC yet.

derfelot commented 2 years ago

Thanks, but I think it's easier to keep the file in line with LOS (with the stuff from Sony stock added). That makes it easier to merge update. I just updated the one in lineage-19.1 branch again. Been a lot longer than i remembered.

Flamefire commented 2 years ago

Sure. To merge updates I introduced the sorting as there are quite a few sources where APNs come from (different stock ROMs, LOS) so it got to hard to find out which ones we already have and potentially changed (e.g. hide the IMS ones)

E.g. you still have a duplicate at https://github.com/whatawurst/android_device_sony_yoshino-common/blob/d82376d732d2b6e274bf717cf3aa8dfe90c5fc0a/config/telephony/apns-conf.xml#L1425-L1426

And a user reported that adding the APNs from upstream AOSP fixed his IMS.

So this just as a note on why I did it this way.