whatawurst / android_device_sony_yoshino-common

This is the Android device configuration for the yoshino platform
10 stars 46 forks source link

DNM: Remove force reboot and make optional reflash of modem #87

Closed shank03 closed 1 year ago

shank03 commented 2 years ago

Unable to test due some work.

Please test before merging :)

shank03 commented 2 years ago

Test time ! :P

shank03 commented 2 years ago

**inserts cricket noises**

derfelot commented 1 year ago

Sorry, haven't had the time to check this out properly recently. Will do so in the coming days.

Unfortunately, I recently switched my network operator, so I don't know if the new one will also have the crashing modem issue without reflash as the old one (O2).

shank03 commented 1 year ago

@Flamefire

Actually the thing is that the apk of CustomizationSelector from stock was decompiled here. And all I did was make the code compilable and readable with variable names, constant names, readable boolean expressions, sensible function/parameter names, etc.

Later I just kept adding changes according to the needs with the reference of format/package structure of the code by mapping which class was responsible for what.

Thus, I haven't done any optimization or validation of code.

So if you find any more bugs like this, please do fix them :)

derfelot commented 1 year ago

So this should be fine to yolo i guess?

Looks like @Flamefire is using the provider i used to have. So if it's fixed there, maybe it's fixed elsewhere ;)

Flamefire commented 1 year ago

Well just had a reboot with this enabled and no network until I switched to 2G (no 3G here anymore). So might not fix this in my case but maybe in others and maybe with the new blobs it is also a different story (wasn't able to make them work with 17.1 yet)

So yeah, can be merged I guess.

derfelot commented 1 year ago

@shank03 please prefix that latest commit title.

shank03 commented 1 year ago

@derfelot my bad. fixed it 👍🏻

derfelot commented 1 year ago

thanks!

yolo time