davegot13
commented
10 years ago Wanted to provide an update. I did some more work and this applies more broadly. If you assign a selector to a jquery variable like:
$myVar = $("#someInput");
if you do $myVar.require(), it works the first time. However, if you call it again, the code doesn't raise an error. This all points back to the validate method where the method sets $obj.reductions to [] in the case nothings passes. When $obj.reductions = [] then that should be treated in the code as undefined (maybe even just set $obj.reductions to undefiend if nothing passes).
whatgoodisaroad
ajwaka
I am using validity for a non-form and ran into this issue when trying to use assert. Here is a snippit of the code I'm trying to use (I know there's a greaterThan operator, but I need to do some custom formatting first):
$.validity.start(); $priceField.assert(priceGreaterCheck, "Price must be greater than 0"); var result = $.validity.end();
function priceGreaterCheck(element) {
var rv = $priceField.asNumber() > 0; return rv; };
The assert call raises the error the first time I try to validate the field. However, if I try to validate the field again, the assert statement returns true even if I don't change the value. The reason I think this is happening is because after the first run through, the validate method is doing
$obj.reduction = $(elements);
which is returning a list of passed elements. However, if nothing passes, then $obj.reduction = [](but not undefined). Therefore in the assert method the line:
var $reduction = this.reduction || this;
is returning [] instead of the object contained in this. This causes
if ($reduction.length)
to evaluate to false and not try the validation which is not the desired behavior. I don't want to modify the validity file so as a workaround I'm doing:
$priceField.reduction = undefined; $priceField.assert(priceGreaterCheck, "Price must be greater than 0");
to force this.reduction || this to always evaluate to this. This is obviously not a permanent solution and should be handled somewhere inside of validity.