search

whatgoodisaroad / validity

Client-Side Validation for jQuery
http://whatgoodisaroad.github.io/validity/
132 stars 75 forks source link

Update jquery.validity.css #49

Closed markvantilburg closed 10 years ago

markvantilburg commented 10 years ago

Most minifiers leave /* comments in the CSS file, using // these comments will be removed from the minified css file

markvantilburg commented 10 years ago

This is also for users that copy/paste the css in a less file.

markvantilburg commented 10 years ago

Thinking about this, it might be better to use a less file for the style in this repository. And generate the .css from this less file. Makes it easier to maintain colors etc.

whatgoodisaroad commented 10 years ago

Comments using // may be recognized by some minifiers, but they're not valid CSS comments.

Are you using a minifier that leaves /* */ comments in? What minifier is that?

markvantilburg commented 10 years ago

I had renamed the .css to .less. The Less compiler puts the /* */ comments in the .css file. Not in the minified version as that is stripped off all comments.

whatgoodisaroad commented 10 years ago

At this point, the CSS in Validity is so simple, I don't see a reason to use less (adding a whole Less compiler to the toolchain). It should be easy to include the Validity CSS rules to your own less stack, though.

The Validity CSS is intended more as a template than as an extra stylesheet for people to include (as noted in the docs).

markvantilburg commented 10 years ago

Ok. To complete the template it might be an idea to include pull/47 to fix 'marking' issues for first time users that use the included css file.