search

whatisnuclear / website

The main whatisnuclear.com website
https://whatisnuclear.com
Other
23 stars 8 forks source link

Fix HTRE image #17

Closed Astlaan closed 3 months ago

Astlaan commented 3 months ago

Hello there!

There were two images in the /img folder that had incorrect names: HTRE-3.jpg and HTRE-3-sm.jpg. They were both pictures of the HTRE-2 reactor, while htre-3.jpg was the actual HTRE-3 photo.

The existence of both HTRE-3.jpg and htre-3.jpg files were also creating a conflict in Windows systems, since the windows filesystem is not case-sensitive. As such, when cloning, one of the images failed to download.

I renamed the files:

I didn't find a clear name case convention for naming the images (most were lower case but some were upper case), so I just kept it as upper case.

I made all the necessary changes in the text, captions and references in order for everything to be consistent. I made changes such that the actual images displayed on the website remain the same, only the text and caption get corrected (and the references as well, due to the file renaming).

I wonder how you found out about reactor concepts as the 630A ahah, you really have to look for it in order to find it. :)

partofthething commented 3 months ago

Amazing, thank you for doing this. I've caught it being wrong in the name before but didn't realize I had the caption wrong on the propulsion page. Great fix.