search

whatsplay / whatsapp-play

Command line software through which you can play with your WhatsApp. It is having different options to play with your WhatsApp like message blast, online tracking, whatsapp chat..
MIT License
405 stars 217 forks source link

Make a clean git history? #120

Open nileshpatra opened 4 years ago

nileshpatra commented 4 years ago

Currently the git history seems very cluttered, making it difficult to keep a track of changes. For example ; this, this, this et. al.

IMO, smaller changes can be squashed to get a sane git history.

xandao-dev commented 4 years ago

Thank you for the feedback! I will improve my commits.

xandao-dev commented 4 years ago

Future commits will be squashed before the PR. @rpotter12

nileshpatra commented 4 years ago

@xandao6 why was the issue closed? I think I wasn't clear, apologies. What I mean was: we can squash some of the unrelated previous commits which you or other authors have made, and force-push?

There are ~300 commits for ~500 lines of code, which doesn't look good.

Pihu1998 commented 4 years ago

Hey, I would like to work on this issue. Can I be assigned this issue?

nileshpatra commented 4 years ago

@Pihu1998 it's probably on us, instead of participants. We need to squash + force-push, and force-push would mean maintainer access to the repository.

A PR can only update the repository by placing commits on top, and not change the order of commits set earlier.

Pihu1998 commented 4 years ago

Oh, I get it now. Thanks for the information. :D

priyansh19 commented 4 years ago

@xandao6 @rpotter12 @nileshpatra Anyone working on this issue?

xandao-dev commented 4 years ago

I think nobody

rpotter12 commented 4 years ago

I will look at this in some days. I'm little busy these days.

arpitasahakundu commented 4 years ago

i want to work on this issue

rpotter12 commented 4 years ago

@arpitasahakundu That's for me. :)