Closed Rits1272 closed 4 years ago
Please review @xandao6 @rpotter12 @priyansh19
Added the screenshot @rpotter12. Please check :)
How should I proceed @rpotter12? Actually I had asked @xandao6 if I should make any change in the changeAbout.py
. So he proposed me the changes as done in this PR.
So in this PR, A user can now have news of any category or keyword
of his liking which will update in every latest news fetch(if any). The category or keyword can be literally anything of the user's choice.
How should I proceed @rpotter12? Actually I had asked @xandao6 if I should make any change in the
changeAbout.py
. So he proposed me the changes as done in this PR.So in this PR, A user can now have news of any
category or keyword
of his liking which will update in every latest news fetch(if any). The category or keyword can be literally anything of the user's choice.
Yes, you can proceed with an idea like if I enter a keyword to find news e.g "corona" then it will display trending 5 news and from which I can select one of them to send
@xandao6 have you added the NEWS_API_KEY
in the .env
file.You can have api key from here
You will need to write a tutorial, otherwise, how can people use this tool?
@Rits1272 Add a Section for this tool in README.md It should contain a few things like :
Quick addon - If you can add the debugging procedure then you may get extra score for that :v:
Here is an overview of what got changed by this pull request:
Issues
======
- Added 3
Complexity decreasing per file
==============================
+ wplay/changeAbout.py -1
See the complete overview on Codacy
I have added the documentation for the changeAbout
in the Readme
file. Please review @priyansh19 @rpotter12 @xandao6
Issue that this pull request solves
Closes: #268
Proposed changes
A user will now be able to change his about the section according to the category of the keyword of news he desires.
Types of changes
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that applyUse :
python3 -m wplay --wabout
.input
the kind of news he wants(for eg. football or coronavirus)