Display all news in changeAbout

Rits1272 commented 4 years ago

Issue that this pull request solves

Closes: #268

Proposed changes

A user will now be able to change his about the section according to the category of the keyword of news he desires.

Types of changes

Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist

Put an x in the boxes that apply

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Use :

The user starts the script with python3 -m wplay --wabout.
The user is then prompted to input the kind of news he wants(for eg. football or coronavirus)
The about section then gets changed with the kind of news opted by the user. The about section keeps changing as soon as the latest news is available.

Screenshot (59)

Rits1272 commented 4 years ago

Please review @xandao6 @rpotter12 @priyansh19

Rits1272 commented 4 years ago

Added the screenshot @rpotter12. Please check :)

Rits1272 commented 4 years ago

How should I proceed @rpotter12? Actually I had asked @xandao6 if I should make any change in the changeAbout.py. So he proposed me the changes as done in this PR.

So in this PR, A user can now have news of any category or keyword of his liking which will update in every latest news fetch(if any). The category or keyword can be literally anything of the user's choice.

priyansh19 commented 4 years ago

How should I proceed @rpotter12? Actually I had asked @xandao6 if I should make any change in the changeAbout.py. So he proposed me the changes as done in this PR.

So in this PR, A user can now have news of any category or keyword of his liking which will update in every latest news fetch(if any). The category or keyword can be literally anything of the user's choice.

Yes, you can proceed with an idea like if I enter a keyword to find news e.g "corona" then it will display trending 5 news and from which I can select one of them to send

Rits1272 commented 4 years ago

@xandao6 have you added the NEWS_API_KEY in the .env file.You can have api key from here

xandao-dev commented 4 years ago

You will need to write a tutorial, otherwise, how can people use this tool?

priyansh19 commented 4 years ago

@Rits1272 Add a Section for this tool in README.md It should contain a few things like :

How to get your own News API keys
How to run this program .. (Fully detailed)

Quick addon - If you can add the debugging procedure then you may get extra score for that :v:

rpotter12 commented 4 years ago

Here is an overview of what got changed by this pull request:


Issues
======
- Added 3

Complexity decreasing per file
==============================
+ wplay/changeAbout.py  -1

See the complete overview on Codacy

Rits1272 commented 4 years ago

I have added the documentation for the changeAbout in the Readme file. Please review @priyansh19 @rpotter12 @xandao6

whatsplay / whatsapp-play