Closed Rits1272 closed 4 years ago
Please review @xandao6 @rpotter12 @priyansh19. Sorry for sending PR late. It actually took me a while to come out with the solution.
Hello @rpotter12 I have mentioned in the screenshot as well as in the description if you want to send message you first need to hit spacebar
. Kindly check :)
add keyboard library to setup.py also.
this error occurs when I use manual target select. Ex: "wplay -wc"
I got a lot of bugs using 'q' to exit,
Hello @rpotter12 I have mentioned in the screenshot as well as in the description if you want to send message you first need to hit
spacebar
. Kindly check :)
@Ritz1272 I am still not able to send message from your implementation. Please check your implementation again and test it again.
keyboard
library in the setup.py
fileq
Please review @rpotter12 @xandao6
Here is an overview of what got changed by this pull request:
Issues
======
- Added 4
Complexity increasing per file
==============================
- wplay/terminal_chat.py 2
Clones removed
==============
+ wplay/terminal_chat.py -2
See the complete overview on Codacy
My screenshot doesnot match with your screenshot. write your message (Enter key for breakline) ('.' alone to send message)
was not found when I ran the software. I think this was your old screenshot.
I am still not able to send message
Issue that this pull request solves
Closes: #77
Types of changes
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that applyScreenshots
Other information
A user can now receive messages in
wchat
. The script will be continuously listening to messages from the target. If a message is sent by the target it will be displayed in the terminal. If a user wants to send a message he simply needs to pressspace bar
. After that, the user can send his message.Initially, @xandao6 suggested using threading. But since
asyncio
is itself always single-threaded it was no feasible to add a thread. So I came out with this solution.