sim12cool commented 4 years ago

Issue that this pull request solves

Closes: # (issue number) https://docs.google.com/document/d/1hMkjEIWWL82P-dqZItmfIurSKFxXx2femCJazBasxAI/edit?usp=sharing

Proposed changes

Brief description of what is fixed or changed

Types of changes

Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist

Put an x in the boxes that apply

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

Screenshots

wapp installed and runned

tracking command

Other information

Any other information that is important to this pull request

xandao-dev commented 4 years ago

You can talk to me in slack for help if you want.

priyansh19 commented 4 years ago

@sim12cool Rebase your current repository and then make a PR. We can discuss this over slack ..

rpotter12 commented 4 years ago

@sim12cool you have not updated your fork properly. Please update your fork forcefully and make a fresh PR for it

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (pull@226a070). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             pull     #287   +/-   ##
=======================================
  Coverage        ?   72.82%           
=======================================
  Files           ?        6           
  Lines           ?      184           
  Branches        ?        0           
=======================================
  Hits            ?      134           
  Misses          ?       50           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 226a070...16e5442. Read the comment docs.