whatsplay / whatsapp-play

Command line software through which you can play with your WhatsApp. It is having different options to play with your WhatsApp like message blast, online tracking, whatsapp chat..
MIT License
403 stars 218 forks source link

Location_finder file added successfully #316

Closed SinghHimadri closed 4 years ago

SinghHimadri commented 4 years ago

Issue that this pull request solves

31

Closes: # (issue number)

Proposed changes

Brief description of what is fixed or changed Currently, the location can be found using number since it requires to enter the number in international format eg:+91888888888 with country code.This can be executes using -wl command then enter the number in valid format.Since format we save our phone numbers is without adding country in future I'll be adding a option to choose a contact or to enter the number manually.This is working successfully It contains some additional information too like Carrier and time zone etc.

Types of changes

Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply

Screenshots

Please attach the screenshots of the changes made in case of change in user interface Screenshot from 2020-04-24 15-00-38

Other information

Any other information that is important to this pull request I would request you to not close this issue as I'll be adding option in this feature.

SinghHimadri commented 4 years ago

@rpotter12 @xandao6 @priyansh19 Please review my PR.

priyansh19 commented 4 years ago

There are some issues in your PR please resolve file complexity

SinghHimadri commented 4 years ago

@SinghHimadri 2 things:

  1. your code should follow PEP8 rule. Install pycodestyle by pip install pycodestyle Then check your changed file by pycodestyle --first <filename> Eg: pycodestyle --first location_finder.py By this you will get all the lines numbers where you are not following PEP8 rule
  2. these code will be more good for target info. So change the file name and arguments according to target_info.

I have done all the changes as directed.

SinghHimadri commented 4 years ago

@rpotter12 @xandao6 I have done all the changes as asked please review.

SinghHimadri commented 4 years ago

There are some issues in your PR please resolve file complexity

I have resolved this please see.

rpotter12 commented 4 years ago

Codacy Here is an overview of what got changed by this pull request:


Complexity increasing per file
==============================
- wplay/target_info.py  16
- wplay/__main__.py  1

See the complete overview on Codacy