Closed SinghHimadri closed 4 years ago
@rpotter12 @xandao6 @priyansh19 Please review my PR.
There are some issues in your PR please resolve file complexity
@SinghHimadri 2 things:
- your code should follow PEP8 rule. Install pycodestyle by
pip install pycodestyle
Then check your changed file bypycodestyle --first <filename>
Eg:pycodestyle --first location_finder.py
By this you will get all the lines numbers where you are not following PEP8 rule- these code will be more good for target info. So change the file name and arguments according to target_info.
I have done all the changes as directed.
@rpotter12 @xandao6 I have done all the changes as asked please review.
There are some issues in your PR please resolve file complexity
I have resolved this please see.
Issue that this pull request solves
31
Closes: # (issue number)
Proposed changes
Brief description of what is fixed or changed Currently, the location can be found using number since it requires to enter the number in international format eg:+91888888888 with country code.This can be executes using -wl command then enter the number in valid format.Since format we save our phone numbers is without adding country in future I'll be adding a option to choose a contact or to enter the number manually.This is working successfully It contains some additional information too like Carrier and time zone etc.
Types of changes
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that applyScreenshots
Please attach the screenshots of the changes made in case of change in user interface![Screenshot from 2020-04-24 15-00-38](https://user-images.githubusercontent.com/36266646/80198090-38a9ca80-863d-11ea-81e0-b7f162e291ce.png)
Other information
Any other information that is important to this pull request I would request you to not close this issue as I'll be adding option in this feature.