whatsplay / whatsapp-play

Command line software through which you can play with your WhatsApp. It is having different options to play with your WhatsApp like message blast, online tracking, whatsapp chat..
MIT License
402 stars 219 forks source link

-wa command working successfully now #349

Closed SinghHimadri closed 4 years ago

SinghHimadri commented 4 years ago

Issue that this pull request solves

347

Closes: # (issue number)

347

Proposed changes

Brief description of what is fixed or changed Error removed command working successfully and changing about now. Also readme has been updated correctly.

Types of changes

Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply

Screenshots

Please attach the screenshots of the changes made in case of change in user interface Screenshot from 2020-05-20 15-42-34

Other information

Any other information that is important to this pull request

SinghHimadri commented 4 years ago

@rpotter12 Please review my PR.

SinghHimadri commented 4 years ago

@SinghHimadri This software is a pypi package. So when a user install it from the command pip install wplay, the user will not able to paste the key in the script. The changes which you have made are only for those users who are running it from source code. :)

The file which is already present requires API key but even after adding API Key the code is showing error due to os.getenv() function. I have just removed that error.Web scrapping is not possible for this website as it requires captcha.Only thing that can be done(according to me) is making a list of eg: 10 keys and randomly placing it for the user. The current file doesn't work I have just removed that error.

rpotter12 commented 4 years ago

@SinghHimadri May be we can ask user to enter api key in terminal for now. What do you say??

priyansh19 commented 4 years ago

We can do one thing .. add a .config file and when the user runs the command the file will be checked if the API keys are not present then we will displays the steps for adding them 😅

priyansh19 commented 4 years ago

Or we can directly take input from CLI also but it will be a bit insecure way of doing so

SinghHimadri commented 4 years ago

@rpotter12 I have done the changes please see.

SinghHimadri commented 4 years ago

@rpotter12 is their some issue left in this PR? I have done the changes you asked.