search

whatwg / compression

Compression Standard
https://compression.spec.whatwg.org/
Other
82 stars 21 forks source link

Editorial: Use enum for the format parameter #53

Closed saschanaz closed 1 year ago

saschanaz commented 1 year ago

Fixes #50

Editorial because this shouldn't change the behavior.

I did not touch the step 1 of the constructors, because IMO it makes sense to keep it in case the spec ever gets more formats (and thus some implementations may have no support for certain formats).

Preview | Diff

ricea commented 1 year ago

Oh, I missed something. Can you do the constructor for DecompressionStream too?

saschanaz commented 1 year ago

Oops, how did I miss it!? Done!

ricea commented 1 year ago

Still lgtm, thanks!

I don't know if Github will let you push the green button, but if not, let me know when you're ready to land it.

saschanaz commented 1 year ago

I hope I didn't miss anything....

I have no write permission, please merge it for me 👍

BTW, should this repo set up https://github.com/w3c/spec-prod for automatic HTML generation?

ricea commented 1 year ago

I've been putting off implementing automatic HTML generation because we're going to migrate somewhere else "soon". Sorry for the trouble.

saschanaz commented 1 year ago

Thanks you!

BTW, will the migration be any trouble for automatic generation? 🤔 I don't think the generation itself was problematic when migrating Web Locks.

ricea commented 1 year ago

I was under the impression it was easier to implement when you were under the w3c or whatwg but I haven't looked recently.