Closed domenic closed 7 years ago
@domfarolino rebased this
@domenic This looks good thanks a lot! My only question is regarding the usage of "info" from my above comment, but as stated we can probably just address https://github.com/whatwg/console/issues/90#issuecomment-289260322 (fancy custom UI per console func) separately; wanted to run it by you though.
Sorry, I can't see your above comment. Yeah, addressing that separately makes sense to me; this preserves the already-existing usage of "info" for now.
Odd, gotcha. I was just curious about the already-existing usage of "info". A picture I included in the elusive review comment was basically:
showing that implementations seem to use some custom "info" however since we'll be taking care of it elsewhere, makes no difference.
Edit: Also I realized that the reason the comment couldn't be seen is because I never actually "submitted" a review, just had it pending or whatever...oh well lol
I wanted to ask what happens when label
is not a string. This PR does not call for a ToString
conversion, so:
ToString
conversion?label
to string with String('label')
?This specification defines
// Timing
void time(optional DOMString label = "default");
void timeEnd(optional DOMString label = "default");
so your answers are found in the Web IDL specification.
@domenic thank you!
Notable changes include the addition of a colon to the output, being explicit about how the implementation decides the format of the duration string, and making the timer table concept explicit.
This also fixes up a few minor linking errors, e.g. two elements having the same ID "group".