whatwg / console

Console Standard
https://console.spec.whatwg.org/
Other
269 stars 67 forks source link

Expose everywhere #209

Closed Ms2ger closed 2 years ago

Ms2ger commented 2 years ago

Ref: https://github.com/tc39/proposal-shadowrealm/issues/331

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

Ms2ger commented 2 years ago

r? @domfarolino

terinjokes commented 2 years ago

LGTM, though I'm wondering if we need to specify the side effects that happen in some of these other environments.

Ms2ger commented 2 years ago

On a first glance, I'm not seeing anything that obviously needs adjusting, but let me know if you disagree.

annevk commented 2 years ago

@terinjokes @domfarolino can you sort out the CI failure? Seems like an image might need width/height attributes?

Ms2ger commented 2 years ago

@domfarolino For tests, I'll make sure to add an idlharness test as soon as the IDL changes propagate into the wpt repo after this PR is merged. I don't think there's much else I can test - maybe a manual test that the messages show up?

domfarolino commented 2 years ago

A manual test would be nice I think

Ms2ger commented 2 years ago

Tests are up at https://github.com/web-platform-tests/wpt/pull/34361

domfarolino commented 2 years ago

This and the tests LGTM. GitHub is complaining about the branch not being up to date, so if you could fix that then I think we'd be good to go.

Ms2ger commented 2 years ago

Done!

domfarolino commented 2 years ago

Great, feel free to merge the tests whenever and I'll go ahead and merge this.

Ms2ger commented 2 years ago

Merged the wpt pr, thank you