search

whatwg / console

Console Standard
https://console.spec.whatwg.org/
Other
269 stars 67 forks source link

Add `console.timeStamp()` to the specification #236

Open bmeurer opened 1 month ago

bmeurer commented 1 month ago

This adds a minimal (vague) definition for the timeStamp() method, based on its current behavior across Chromium, Firefox, and Safari, and the MDN documentation^1.

Ref: #140

Preview | Diff

bmeurer commented 1 month ago

@domfarolino Let's get the ball rolling here. :muscle:

@and-oli Please loop in your contacts with other browser vendors here.

domfarolino commented 1 month ago

Hmm, it looks like you removed this line about tests from the pull request template? Can you add that back and maybe write some tests for this API? You can follow the pattern in https://github.com/web-platform-tests/wpt/tree/master/console. Note the state of testing is a little sad at this point, since these are basically just manual tests :(

and-oli commented 1 month ago

@dcrousso @nchevobbe

bmeurer commented 1 month ago

Hmm, it looks like you removed this line about tests from the pull request template? Can you add that back and maybe write some tests for this API? You can follow the pattern in https://github.com/web-platform-tests/wpt/tree/master/console. Note the state of testing is a little sad at this point, since these are basically just manual tests :(

Beyond testing that the function exists on the console object, how would we go about adding other (meaningful) tests?

bmeurer commented 1 month ago

Hmm, it looks like you removed this line about tests from the pull request template? Can you add that back and maybe write some tests for this API? You can follow the pattern in https://github.com/web-platform-tests/wpt/tree/master/console. Note the state of testing is a little sad at this point, since these are basically just manual tests :(

Beyond testing that the function exists on the console object, how would we go about adding other (meaningful) tests?

@domfarolino any thoughts here?