search

whatwg / fetch

Fetch Standard
https://fetch.spec.whatwg.org/
Other
2.12k stars 333 forks source link

keepalive requests are terminated when they shouldn't be? #1669

Open smaug---- opened 1 year ago

smaug---- commented 1 year ago

https://fetch.spec.whatwg.org/#fetch-groups says "whose request’s done flag is unset or keepalive is false"

I think that should use "and", not "or". We don't want to cancel not-done keepalives there, I believe.

annevk commented 1 year ago

@noamr maybe fix this as part of #1647 or rather after? I believe that PR is changing this line already.

I went back through blame when this was first mentioned on Chat and I believe it's always been wrong.

noamr commented 1 year ago

@noamr maybe fix this as part of #1647 or rather after? I believe that PR is changing this line already.

I went back through blame when this was first mentioned on Chat and I believe it's always been wrong.

Done. That PR is ready for review.