search

whatwg / fs

File System Standard
https://fs.spec.whatwg.org/
Other
224 stars 19 forks source link

Editorial: Properly format enum strings #134

Closed a-sully closed 1 year ago

a-sully commented 1 year ago

Before: {{WriteCommandType/"write"}} After: "{{WriteCommandType/write}}"

Fixes #133

Preview | Diff

a-sully commented 1 year ago

Question: should strings like "readwrite" be converted to "{{FileSystemPermissionMode/readwrite}}"? Presumably that would require moving the declaration of FileSystemPermissionMode to this spec, though. Not sure if that's something we want to do

inexorabletash commented 1 year ago

I defer to Anne of course, but if they're internal state not enum members, then I'd keep them as strings. I'd use https://fetch.spec.whatwg.org/#fetch-controller-state as an analogue.