search

whatwg / fs

File System Standard
https://fs.spec.whatwg.org/
Other
233 stars 19 forks source link

Editorial: Don't use dot access in most places #90

Closed a-sully closed 1 year ago

a-sully commented 1 year ago

See https://github.com/whatwg/fs/pull/87#discussion_r1068229665

Preview | Diff

a-sully commented 1 year ago

I believe none of the other instances of dot access are for "concepts" but please correct me if I'm wrong

annevk commented 1 year ago

So accessing dictionary members through dots is also wrong. Dictionaries are to be treated as maps.

I think the only correct dot usage is in serialization and deserialization.

a-sully commented 1 year ago

Rebased this on the infra changes introduced in #95 (and updated to remove use of dot access in most places, as you suggest in your last comment). PTAL?

a-sully commented 1 year ago

Feel free to merge if this looks good. Thanks!