search

whatwg / fullscreen

Fullscreen API Standard
https://fullscreen.spec.whatwg.org/
Other
105 stars 43 forks source link

Consider forbidding <frame> element from entering fullscreen #112

Open upsuper opened 6 years ago

upsuper commented 6 years ago

It seems that <frame> element is not allowed to be out-of-flow, so it's incompatible with the top layer model, like internal SVG and MathML elements. And it is a deprecated tech anyway.

I propose that we add <frame> element to the same place where we rule out <dialog> from entering fullscreen.

(This was raised from a fuzzy bug which triggers an internal assertion in Gecko.)

foolip commented 6 years ago

Fullscreen inside of <frame> used to work in Chromium. But here it's frame.requestFullscreen() so not exactly the situation. Disallowing this would be straightforward and fine I think, unlikely to be a web compat problem. Care to send spec+test PRs?

upsuper commented 6 years ago

Fullscreen inside of <frame> should have been forbidden by the "allowed to use" algorithm anyway. Also <frame> being able to enter fullscreen is the prerequisite for its content to do so, like <iframe>.

It is not clear to me how would fullscreen be applied for <frame> given that it cannot go out-of-flow...

I can do the spec+test... when I have time at some point...

foolip commented 6 years ago

Fullscreen inside of <frame> should have been forbidden by the "allowed to use" algorithm anyway.

Right, but it used to work, is all, which just means that whatever the problem is in Gecko probably doesn't apply to Chromium. I'm still fine with not allowing it.

annevk commented 6 years ago

Does this also apply to frameset?