Use HTML checker binary image, not system Java

whatwg / html-build

Build scripts for https://github.com/whatwg/html

Other

62 stars 61 forks source link

Use HTML checker binary image, not system Java #198

Closed sideshowbarker closed 5 years ago

sideshowbarker commented 5 years ago

This change makes the HTML-spec deploy build download and use the (Linux) binary image of the HTML checker rather than downloading and using the jar release of the checker and relying on using a system Java runtime to run that jar.

Note that we call ./vnu-runtime-image/bin/java rather than the ./vnu-runtime-image/bin/vnu convenience wrapper script because we need to feed java the -Xmx1g argument.

sideshowbarker commented 5 years ago

LGTM. While here, maybe add a comment documenting what Xmx1g does?

OK, yup, added in 0f7bb2c