search

whatwg / html-build

Build scripts for https://github.com/whatwg/html
Other
62 stars 61 forks source link

Add instructions for updating submodules #206

Closed annevk closed 4 years ago

annevk commented 4 years ago

I had to do this and I had to look it up.

domenic commented 4 years ago

If users have to do this then the build.sh is not working correctly, so we should fix that.

Can you reproduce with a fresh checkout?

annevk commented 4 years ago

I had an old checkout, then I do git pull, and then submodules end up in an inconsistent state. This will happen whenever we update the submodules.

domenic commented 4 years ago

OK, we will need to update the build.sh to fix that then, like it is currently supposed to be doing on line 45. We should not make people do this by hand.

sideshowbarker commented 4 years ago

@annevk Are you invoking the script with ./build.sh with no arguments, or are you invoking it with ./build.sh -n or ./build.sh -no-update?

annevk commented 4 years ago

I used -n, maybe that's it.

sideshowbarker commented 4 years ago

I used -n, maybe that's it.

Yeah, in that case, it’s intended behavior that it doesn’t update submodules