whatwg / html-build

Build scripts for https://github.com/whatwg/html
Other
64 stars 61 forks source link

"Improvements to the CI Docker build" broken PDF links #255

Closed domenic closed 4 years ago

domenic commented 4 years ago

I was noticing a bunch of warnings in the pdfsizeopt output, but I figured they would be fine. Oops. I just tested the output and all the links are broken.

I suspect upgrading Prince caused this. Will investigate.

domenic commented 4 years ago

I've filed the details of my investigation here: https://github.com/pts/pdfsizeopt/issues/145. The PDFs produced by Prince 12 and 13 indeed interact poorly with pdfsizeopt.

We have two options: removing pdfsizeopt, and reverting to Prince 11. Some relevant statistics:

Since I don't know of any ways in which the Prince 13 result is better than the Prince 11 result, on balance I will prefer saving 2.6 MB, and reverting to Prince 11. But, we should keep this in mind for the future. If we ever have more problems with pdfsizeopt, or we need some new feature of Prince, we can take the other path.