Remove Perl preprocessing scripts

whatwg / html-build

Build scripts for https://github.com/whatwg/html

Other

62 stars 62 forks source link

Remove Perl preprocessing scripts #285

Closed domenic closed 10 months ago

domenic commented 10 months ago

They were replaced by Rust versions in 188742d66b10cc254d2bbb636a0b7f6380de2832. Now that the --remote build is available, we should not keep these two code paths around.

Closes #234.

On top of #283 and should not be merged before that is.

Sadly perl is still needed for lint.sh.

sideshowbarker commented 10 months ago

I guess it needs to handle the case where ./build.sh is called with no arguments — specifically, without either the --verbose or --quiet arguments

domenic commented 10 months ago

Oh dear... cannot reproduce. Can you reproduce on main with PROCESS_WITH_RUST=true ./build.sh?

sideshowbarker commented 10 months ago

Oh dear... cannot reproduce.

It might be a difference in bash versions. I have bash 5.2.15 in my environment

Can you reproduce on main with PROCESS_WITH_RUST=true ./build.sh?

Yup