Make drag & drop events composed

whatwg / html

HTML Standard

https://html.spec.whatwg.org/multipage/

Other

8.09k stars 2.66k forks source link

Make drag & drop events composed #1922

Open annevk opened 8 years ago

annevk commented 8 years ago

Discussed this with @rniwa.

click()
contextmenu (most likely)
drag & drop? (not discussed)

annevk commented 7 years ago

@hayatoito any thoughts on this?

I'm happy to tackle click() and contextmenu, but drag & drop seems like its own can of worms in that I'm not sure how well everything there matches implementations to begin with.

hayatoito commented 7 years ago

click() - I prefer composed events for click(), which matches Blink's current implementation.
contextmenu - I do not have a strong opinion, but it sounds UI-ish Events. I am fine to make it a composed event.
drag & drop - Hmm. I remember that I thought of this event. However, for some reasons, I deferred the decision. Maybe this is not easy to define how drag & drop should work across Shadow DOM boundaries. Let me think again about it later.

annevk commented 7 years ago

Synthetic contextmenu event dispatching went away in e7e8c88ecdd7cdc96171f05ab6fe23b56dd48d8a. #2999 has a patch for synthetic mouse events. That leaves drag & drop.

domenic commented 7 years ago

@annevk I think the contextmenu event is unrelated to the menu element. It's basically a right-click event.

annevk commented 7 years ago

@domenic the commit I pointed to had the only text that actually ended up dispatching an event named contextmenu as far as I can tell.

annevk commented 7 years ago

(I suspect UI Events might (should) have similar text, but that's not the HTML Standard.)

annevk commented 7 years ago

So the remaining open question here is whether drag & drop events need to be composed. They are UI Events of sorts so that would suggest they should be, but there might be some complications I'm not aware of. Input welcome from @whatwg/components and whoever else has opinions.