search

whatwg / loader

Loader Standard
https://whatwg.github.io/loader/
Creative Commons Zero v1.0 Universal
607 stars 45 forks source link

4.1.7 Instantiation: ParseModule called with two arguments, only accepts one #46

Closed ajklein closed 8 years ago

ajklein commented 9 years ago

I think you can just leave off the Realm argument.

caridy commented 9 years ago

c159b5c5ec60f3e78e484c3f3f884061d0f5c6c3

caridy commented 8 years ago

the extra step to set [[Realm]] to the loader.[[Realm]] is not needed anymore, this is now fixed in 262, and [[Realm]] is set to the running execution context's Realm in ParseModule(): http://tc39.github.io/ecma262/#sec-parsemodule

caridy commented 8 years ago

Accidentally reopened, I will create a new issue to track this change.

domenic commented 8 years ago

But see https://github.com/tc39/ecma262/pull/275 which tweaks this a little bit

caridy commented 8 years ago

ok, will track this issue here: https://github.com/whatwg/loader/issues/118