Review draft PR creation

whatwg / meta

Discussions and issues without a logical home

Creative Commons Zero v1.0 Universal

93 stars 159 forks source link

Review draft PR creation #175

Closed annevk closed 4 years ago

annevk commented 4 years ago

I guess the problem with makeGroupsOfFive is that if we add a standard while the current process is still ongoing, it might cause another standard to be published again a month later. So maybe @foolip's approach of hardcoding months (see https://github.com/whatwg/sg/issues/127) in db.json is the way to go.

domenic commented 4 years ago

+1 for hardcoding months; I like the predictability, and it might even be information we want to surface somewhere someday (e.g. on https://whatwg.org/workstreams)

annevk commented 4 years ago

Months are part of db.json now. The way I was thinking of taking this further in July:

No need for arguments, just get the current month.
If the current day is far from the third Monday of the month, maybe log a warning.
Get all the relevant standards for the month and create PRs for them.
Optionally, migrate more of make preview into this script rather than have that spread out across our various standards.

cc @foolip

annevk commented 4 years ago

@foolip (and @domenic) this is now updated to take into account the updated db.json. We could try it out on Monday. Suggestions and such welcome as well as thoughts on the "Optionally" above and the things called out in comments.