search

whatwg / meta

Discussions and issues without a logical home
Creative Commons Zero v1.0 Universal
93 stars 161 forks source link

review.sh / HTML's review-draft.sh do not work on Linux #253

Closed domenic closed 1 year ago

domenic commented 1 year ago

Apparently the -i '' option to sed is a macOS-ism. See https://stackoverflow.com/a/43453459 and https://unix.stackexchange.com/a/131940 .

I was thinking of trying to fix this but I noticed 

    # We should consider merging
    # https://github.com/whatwg/whatwg.org/blob/main/resources.whatwg.org/build/review.sh and
    # https://github.com/whatwg/html/blob/main/review-draft.sh into this script.

which I tend to agree would be a better path. @annevk do you have any interest in giving that a try?

domenic commented 1 year ago

I ended up doing this myself, I couldn't resist...