search

whatwg / meta

Discussions and issues without a logical home
Creative Commons Zero v1.0 Universal
93 stars 161 forks source link

Merge "make review" scripts into review.py #254

Closed domenic closed 1 year ago

domenic commented 1 year ago

Fixes #253.

I tested this locally but did not test the PR creation. But, that code is unchanged, so maybe it'll be fine?

Python review appreciated, I don't write a lot.

domenic commented 1 year ago

Thanks for the review Adam! And especially for the tip on f-strings; that's much nicer.

domenic commented 1 year ago

This looks good, but we still need the ability to regenerate a single review draft in case something is wrong with the main branch at publication times.

How about allowing an argument to review.py to specify a particular one? It will do everything but PR creation?

annevk commented 1 year ago

Yeah, I think that would work. Although you want to avoid branch swapping as well in that case so you can fix an existing branch.

domenic commented 1 year ago

My idea is to just force-delete and recreate the existing branch.

annevk commented 1 year ago

If you then force push it will it end up overwriting the correct PR?

domenic commented 1 year ago

Yeah because the branch name hasn't changed. You might have to use -u origin HEAD to reestablish the connection to the remote branch, I guess.