search

whatwg / misc-server

Miscellaneous resources for the servers hosting *.whatwg.org domains
Other
23 stars 16 forks source link

Add WHATWG-themed CSS for nginx directory listings #79

Closed sideshowbarker closed 6 years ago

sideshowbarker commented 6 years ago

Fixes https://github.com/whatwg/whatwg.org/issues/91

annevk commented 6 years ago

I guess that means we first need to add that resource? (If you just put it there it won't work as we use rsync.)

sideshowbarker commented 6 years ago

I guess that means we first need to add that resource? (If you just put it there it won't work as we use rsync.)

Yeah I know, am working on a separate PR for that now

annevk commented 6 years ago

According to https://github.com/aperezdc/ngx-fancyindex/blob/master/README.rst#fancyindex-css-href this doesn't replace any built-in styles so we'd end up loading two stylesheets just for directory listing. Not exactly ideal, but I guess acceptable? We'll have to make sure my suggestion ends up overwriting the defaults though.

sideshowbarker commented 6 years ago

According to https://github.com/aperezdc/ngx-fancyindex/blob/master/README.rst#fancyindex-css-href this doesn't replace any built-in styles so we'd end up loading two stylesheets just directory listing. Not exactly ideal, but I guess acceptable? We'll have to make sure my suggestion ends up overwriting the defaults though.

The description there says:

The link is inserted after the built-in CSS rules, so you can override the default styles.

So that seems to make it clear that styles in the default stylesheet definitely get overridden by any corresponding styles in the stylesheet specified as the fancyindex_css_href value.

…we'd end up loading two stylesheets… Not exactly ideal, but I guess acceptable?

I don’t know that we have any alternative — well, other than hacking the installed ngx-fancyindex sources in the server environment to replace the defaults. Because as far as I can see, it doesn’t expose any way to programatically replace the defaults — instead it only lets you specify an additional stylesheet to override them.

annevk commented 6 years ago

It seems the builtin style sheet is <style> so it's not too bad, but I filed https://github.com/aperezdc/ngx-fancyindex/issues/79 anyway in the hopes of improving this at some future point.