whatwg / notifications

Notifications API Standard
https://notifications.spec.whatwg.org/
Other
139 stars 49 forks source link

Default silent to platform convention #194

Closed marcoscaceres closed 1 year ago

marcoscaceres commented 1 year ago

Closes #193

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

rayankans commented 1 year ago

Thanks for the proposal Marcos, agreed that the default should be platform specific, and is an overall improvement. The change looks good to me, and happy to apply the changes from the chromium side of things.

marcoscaceres commented 1 year ago

Small set of tests are coming as part of https://github.com/WebKit/WebKit/pull/13912

(reviewed upstream)

I’ll send them to WPT hopefully tomorrow.

marcoscaceres commented 1 year ago

Implementer bugs filed.

marcoscaceres commented 1 year ago

Tests sent at https://github.com/web-platform-tests/wpt/pull/40160 (reviewed upstream)