whatwg / spec-factory

WHATWG Standard repository templates and infrastructure
Creative Commons Zero v1.0 Universal
34 stars 33 forks source link

Add whatwg/storage configs #44

Closed saschanaz closed 1 year ago

saschanaz commented 1 year ago

Corresponds to https://github.com/whatwg/storage/pull/152.

saschanaz commented 1 year ago

Hmm, looking at https://github.com/whatwg/storage/actions/runs/3531622937/jobs/5924996674 we seemingly need pre_build_step instead of the post one. I guess for now we should just checkin the SVG file, what do you think? @domenic

saschanaz commented 1 year ago

(Can we fix https://resources.whatwg.org/build/deploy.sh instead?)

domenic commented 1 year ago

Yeah, maybe we should just reverse the order of copy_extra_files and run_post_build_step? The one to check would be whatwg/encoding; does that depend on the current ordering, or can be it be made to work with the opposite order?

saschanaz commented 1 year ago

Not even sure how is it working right now? It generates files after copy?

domenic commented 1 year ago

Yep, that's how it's working right now:

curlbikeshed "$INPUT_FILE" \
             "$WEB_ROOT/index.html" \
             -F md-Text-Macro="COMMIT-SHA $SHA"
copy_extra_files "$WEB_ROOT"
run_post_build_step "$WEB_ROOT"
echo "Living standard output to $WEB_ROOT"
saschanaz commented 1 year ago

Oh I mean, not sure how Encoding is happy with that... Is it really getting the generated files?

annevk commented 1 year ago

@saschanaz Encoding just generates a bunch of additional files. Those files are themselves not inputs to anything else.

saschanaz commented 1 year ago

But they should be served to be referenced via anchor elements, no?

saschanaz commented 1 year ago

I mean the resulting files from visualize.py, which is called as a post build step. But that script interestingly directly writes to the web root. Got it 🙂