whatwg / storage

Storage Standard
https://storage.spec.whatwg.org/
Other
126 stars 55 forks source link

Swap browsing session for traversable #148

Closed jakearchibald closed 2 years ago

jakearchibald commented 2 years ago

This makes storage compatible with https://github.com/whatwg/html/pull/6315


Preview | Diff

jakearchibald commented 2 years ago

@domenic I'm a little unclear on how Wattsi <-> bikeshed compatibility is handled. Does this plan sound ok?

domenic commented 2 years ago

Does this plan sound ok?

Basically yes. We don't need for=/ at the definition side, and I'm wondering if it should be for=node anyway, but probably not.

I can do the dfn-stuff updates :)

domenic commented 2 years ago

I can do the dfn-stuff updates :)

Done in https://github.com/whatwg/html/pull/6315/commits/0caab9ce095694d10844979dac7b8d217d32e270 . I'll leave it to you to remove

JAKE-TODO: The storage spec uses sessions. It probably should be traversables.

which presumably involves fixing up the previous line.

domenic commented 2 years ago

I'll leave it to you

I couldn't resist, and I did it myself: https://github.com/whatwg/html/pull/6315/commits/f067254aeccfecba52738e3cb43d609615a0a388

jakearchibald commented 2 years ago

@annevk I think this is ready now! Are you happy using bikeshed's oldids feature?

annevk commented 2 years ago

Thanks @jakearchibald!