Use `(ArrayBufferView or undefined)` for ReadableStreamBYOBReadResult

whatwg / streams

Streams Standard

https://streams.spec.whatwg.org/

Other

1.35k stars 160 forks source link

Use `(ArrayBufferView or undefined)` for ReadableStreamBYOBReadResult #1214

Closed saschanaz closed 2 years ago

saschanaz commented 2 years ago

Closes https://github.com/whatwg/webidl/issues/1094.

[ ] At least two implementers are interested (and none opposed):
- …
- …
[x] Tests are written and can be reviewed and commented upon at:
- https://github.com/web-platform-tests/wpt/blob/62c22e4362e19418022e03ca4f5bea76b998fa3f/streams/readable-byte-streams/tee.any.js#L503
[ ] Implementation bugs are filed:
- Chrome: …
- Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1752880
- Safari: …
- Deno: …
- Node.js: …

(See WHATWG Working Mode: Changes for more details.)

Preview | Diff

saschanaz commented 2 years ago

I think that's what I exactly did here?

MattiasBuelens commented 2 years ago

🤦‍♂️

Sorry, I meant: could you also update the .idl file in the reference implementation? That one should be kept in sync with the spec text. (Even though, in this particular case, it doesn't really affect the behavior of the reference implementation.)

ricea commented 2 years ago

I'm not sure if we need implementer interest since this is just a bugfix, but just in case we do, Chrome is interested.

MattiasBuelens commented 2 years ago

Yeah, I'd say this change is mostly editorial. The tests already require that value is undefined in several cases, so I don't think we need to ask for interest or file implementation bugs.