Add an abstraction to pull from buffer into ReadableStream

whatwg / streams

Streams Standard

https://streams.spec.whatwg.org/

Other

1.35k stars 160 forks source link

Closed saschanaz closed 1 year ago

saschanaz commented 1 year ago

[x] At least two implementers are interested (and none opposed): N/A, just moving existing steps from Fetch to Streams
[x] Tests are written and can be reviewed and commented upon at: Same
[x] Implementation bugs are filed: N/A
[x] MDN issue is filed: N/A

saschanaz commented 1 year ago

Good point! Using byte sequence sounds good to me. But we still have no definition for the operations, right?

domenic commented 1 year ago

Well, yes, but we have length. And I feel less bad about using common-sense definitions if the base type is well-defined. So:

We can use length instead of size
We can use "Append" because it's straightforwardly clear
For "Extract", I'd feel better if we broke it down into "Let x be the first Y bytes of Z", "Remove the first Y bytes from Z". Then the common-sense definitions are very clear.