whatwg / streams

Streams Standard
https://streams.spec.whatwg.org/
Other
1.35k stars 160 forks source link

Editorial: update WPT #1264

Closed MattiasBuelens closed 1 year ago

MattiasBuelens commented 1 year ago

It looks like it's been a while since we synced the reference implementation with the latest WPT. This aims to fix that.

The following errors came up:

ricea commented 1 year ago

I'm not entirely sure what the intention was here: does the spec need to be updated for this? confused

Yes. This is #1243. We plan to update the spec to require a microtask between enqueue() and write(), but we haven't done it yet.

youennf commented 1 year ago

Yes. This is #1243. We plan to update the spec to require a microtask between enqueue() and write(), but we haven't done it yet.

Is #1243 easily resolvable? Another approach would be to move this specific test in a separate file and disable it in this repo until #1243 can be resolved.

youennf commented 1 year ago

https://github.com/whatwg/streams/pull/1282 is a new attempt at fixing the same issue. It basically takes this PR and add a few additional changes. PR CI is green.

youennf commented 1 year ago

Shall we close this one?

MattiasBuelens commented 1 year ago

Closing, because superseded by #1282.