Editorial: clarify the types of strings algorithms take and return

whatwg / url

URL Standard

https://url.spec.whatwg.org/

Other

526 stars 137 forks source link

Editorial: clarify the types of strings algorithms take and return #719

Closed annevk closed 1 year ago

annevk commented 1 year ago

Given the existing callers these are not normative changes, but there was definitely a lack of clarity.

Closes https://github.com/web-platform-tests/wpt/issues/37010.

Preview | Diff

annevk commented 1 year ago

@karwa would you be willing to review this? Would be nice to get your perspective.

Gallaecio commented 1 year ago

Do the 2 examples in https://url.spec.whatwg.org/#example-percent-encode-operations that have %26 in the output need to be updated with a different output expectation, then?

annevk commented 1 year ago

No those are correct. That only happens when a particular code point cannot be encoded in the target encoding though. (So it'll never happen for UTF-8.)